On Sat, Apr 28, 2007 at 11:44:43AM +0400, Alexey Dobriyan wrote: > On 4/28/07, Akinobu Mita <[EMAIL PROTECTED]> wrote: > >init_hugetlbfs_fs() needs to unregister hugetlbfs > >when kern_mount() returns error. > > HUGETLBFS is bool, so __init function should panic more and > __exit function should be removed. Or someone is planning > making it tristate?
Seems reasonable to make it panic. Because hugetlbfs_vfsmount is not initialized when error happen, and shmget() (ipc/shm.c) can cause NULL pointer dereference by hugetlb_zero_setup(). Or we can add NULL check for hugetlbfs_vfsmount in hugetlbfs_vfsmount(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
