On Fri, Sep 22, 2017 at 6:02 AM, Jean-Philippe Brucker <jean-philippe.bruc...@arm.com> wrote: > On 22/09/17 10:02, Joerg Roedel wrote: >> On Tue, Sep 19, 2017 at 10:23:43AM -0400, Rob Clark wrote: >>> I would like to decide in the IRQ whether or not to queue work or not, >>> because when we get a gpu fault, we tend to get 1000's of gpu faults >>> all at once (and I really only need to handle the first one). I >>> suppose that could also be achieved by having a special return value >>> from the fault handler to say "call me again from a wq".. >>> >>> Note that in the drm driver I already have a suitable wq to queue the >>> work, so it really doesn't buy me anything to have the iommu driver >>> toss things off to a wq for me. Might be a different situation for >>> other drivers (but I guess mostly other drivers are using iommu API >>> indirectly via dma-mapping?) >> >> Okay, so since you are the only user for now, we don't need a >> work-queue. But I still want the ->resume call-back to be hidden in the >> iommu code and not be exposed to users. >> >> We already have per-domain fault-handlers, so the best solution for now >> is to call ->resume from report_iommu_fault() when the fault-handler >> returns a special value. > > The problem is that report_iommu_fault is called from IRQ context by the > SMMU driver, so the device driver callback cannot sleep. > > So if the device driver needs to be able to sleep between fault report and > resume, as I understand Rob needs for writing debugfs, we can either: > > * call report_iommu_fault from higher up, in a thread or workqueue. > * split the fault reporting as this patch proposes. The exact same > mechanism is needed for the vSVM work by Intel: in order to inject fault > into the guest, they would like to have an atomic notifier registered by > VFIO for passing down the Page Request, and a new function in the IOMMU > API to resume/complete the fault. >
I'm in favour if splitting the reporting *somehow*.. the two approaches that seemed sane are: 1) call fault handler from irq and having separate domain->resume() called by the driver, potentially from a wq 2) or having two fault callbacks, first called before wq and then based on returned value, optionally 2nd callback called from wq The first seemed less intrusive to me, but I'm flexible. BR, -R
