On Mon, 25 Sep 2017 14:07:48 +0200
Peter Zijlstra <[email protected]> wrote:
> +static inline char __task_state_to_char(unsigned int state)
> +{
> + static const char state_char[] = "RSDTtXZ";
> +
> + BUILD_BUG_ON(1 + ilog2(TASK_REPORT) != sizeof(state_char) - 2);
>
> - return state < sizeof(stat_nam) - 1 ? stat_nam[state] : '?';
> + return state_char[state];
> +}
> +
> +static inline char task_state_to_char(struct task_struct *tsk)
> +{
> + return __task_state_to_char(__get_task_state(tsk));
> }
>
So far I'm fine with the patch set, but I hate the non descriptive "__"
prefix of __task_state_to_char(). Can we make this a bit more
descriptive, because every time I see it in other patches, I go back to
this patch to see if we are using the right function.
What about something like:
task_state_to_state_char(unsigned int state);
task_to_state_char(struct task_struct *tsk);
?
This way, the "__" wont keep making me think we used the wrong
function.
-- Steve
