[PATCH review for 4.9 40/50] vfs: open() with O_CREAT should not create inodes with unknown ids

[Levin, Alexander (Sasha Levin)]

From: Seth Forshee <seth.fors...@canonical.com>

[ Upstream commit 1328c727004d432bbdfba0ffa02a166df04c7305 ]

may_create() rejects creation of inodes with ids which lack a
mapping into s_user_ns. However for O_CREAT may_o_create() is
is used instead. Add a similar check there.

Fixes: 036d523641c6 ("vfs: Don't create inodes with a uid or gid unknown to the 
vfs")
Signed-off-by: Seth Forshee <seth.fors...@canonical.com>
Signed-off-by: "Eric W. Biederman" <ebied...@xmission.com>
Signed-off-by: Sasha Levin <alexander.le...@verizon.com>
---
 fs/namei.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/namei.c b/fs/namei.c
index 66209f720146..e7d125c23aa6 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2971,10 +2971,16 @@ static inline int open_to_namei_flags(int flag)
 
 static int may_o_create(const struct path *dir, struct dentry *dentry, umode_t 
mode)
 {
+       struct user_namespace *s_user_ns;
        int error = security_path_mknod(dir, dentry, mode, 0);
        if (error)
                return error;
 
+       s_user_ns = dir->dentry->d_sb->s_user_ns;
+       if (!kuid_has_mapping(s_user_ns, current_fsuid()) ||
+           !kgid_has_mapping(s_user_ns, current_fsgid()))
+               return -EOVERFLOW;
+
        error = inode_permission(dir->dentry->d_inode, MAY_WRITE | MAY_EXEC);
        if (error)
                return error;
-- 
2.11.0