Hi Suzuki, On Fri, Oct 06, 2017 at 11:36:07AM +0100, Suzuki K Poulose wrote: > Reuse the new generic helper, of_cpu_node_to_id() to map a > given CPU phandle to a logical CPU number. > > Cc: Leo Yan <[email protected]> > Acked-by: Mathieu Poirier <[email protected]> > Signed-off-by: Suzuki K Poulose <[email protected]>
Tested-by: Leo Yan <[email protected]> BTW, I think the function get_cpu_for_node() in the file arch/arm64/kernel/topology.c we also can refactor with the same function, just reminding for this. > --- > Changes since V4: > - Fix a regression introduced in v4, reported by bugrobot > Changes since V3: > - Reflect the renaming of the helper and return value changes > --- > drivers/hwtracing/coresight/of_coresight.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/hwtracing/coresight/of_coresight.c > b/drivers/hwtracing/coresight/of_coresight.c > index a18794128bf8..7c375443ede6 100644 > --- a/drivers/hwtracing/coresight/of_coresight.c > +++ b/drivers/hwtracing/coresight/of_coresight.c > @@ -104,26 +104,17 @@ static int of_coresight_alloc_memory(struct device *dev, > int of_coresight_get_cpu(const struct device_node *node) > { > int cpu; > - bool found; > - struct device_node *dn, *np; > + struct device_node *dn; > > dn = of_parse_phandle(node, "cpu", 0); > - > /* Affinity defaults to CPU0 */ > if (!dn) > return 0; > - > - for_each_possible_cpu(cpu) { > - np = of_cpu_device_node_get(cpu); > - found = (dn == np); > - of_node_put(np); > - if (found) > - break; > - } > + cpu = of_cpu_node_to_id(dn); > of_node_put(dn); > > /* Affinity to CPU0 if no cpu nodes are found */ > - return found ? cpu : 0; > + return (cpu < 0) ? 0 : cpu; > } > EXPORT_SYMBOL_GPL(of_coresight_get_cpu); > > -- > 2.13.6 >
