On 12.10.2017 13:57, Jon Hunter wrote:
>
> On 12/10/17 11:51, Dmitry Osipenko wrote:
>> On 12.10.2017 11:49, Jon Hunter wrote:
>>>
>>> On 11/10/17 21:08, Dmitry Osipenko wrote:
>>>> Add a device node for the video decoder engine found on Tegra20.
>>>>
>>>> Signed-off-by: Dmitry Osipenko <dig...@gmail.com>
>>>> ---
>>>> arch/arm/boot/dts/tegra20.dtsi | 17 +++++++++++++++++
>>>> 1 file changed, 17 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/tegra20.dtsi
>>>> b/arch/arm/boot/dts/tegra20.dtsi
>>>> index 7c85f97f72ea..1b5d54b6c0cb 100644
>>>> --- a/arch/arm/boot/dts/tegra20.dtsi
>>>> +++ b/arch/arm/boot/dts/tegra20.dtsi
>>>> @@ -249,6 +249,23 @@
>>>> */
>>>> };
>>>>
>>>> + vde@6001a000 {
>>>> + compatible = "nvidia,tegra20-vde";
>>>> + reg = <0x6001a000 0x3D00 /* VDE registers */
>>>> + 0x40000400 0x3FC00>; /* IRAM region */
>>>> + reg-names = "regs", "iram";
>>>> + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>, /* UCQ error
>>>> interrupt */
>>>> + <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, /* Sync token
>>>> interrupt */
>>>> + <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, /* BSE-V
>>>> interrupt */
>>>> + <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>, /* BSE-A
>>>> interrupt */
>>>> + <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; /* SXE interrupt
>>>> */
>>>> + interrupt-names = "ucq-error", "sync-token", "bsev", "bsea",
>>>> "sxe";
>>>> + clocks = <&tegra_car TEGRA20_CLK_VDE>;
>>>> + clock-names = "vde";
>>>> + resets = <&tegra_car 61>;
>>>> + reset-names = "vde";
>>>> + };
>>>> +
>>>
>>> I don't see any binding documentation for this node. We need to make
>>> sure we add this.
>>>
>>
>> It's in the first patch.
>>
>> +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-vde.txt
>>
>
> Ah yes indeed, then that needs to be a separate patch.
>
Okay
