On 10/12/2017 09:35 AM, Shuah Khan wrote:
> On 10/12/2017 09:25 AM, Xin Long wrote:
>> On Thu, Oct 12, 2017 at 11:18 PM, Andreas Radke
>> <andreas.ra...@mailbox.org> wrote:
>>> Building the 4.9.x kernel package for Arch Linux 4.9.55 gives this IPv4
>>> error here:
>>>
>>> Job for dhcpd4.service failed because the control process exited with error
>>> code.
>>> See "systemctl status dhcpd4.service" and "journalctl -xe" for details.
>>> root@server64:/root # systemctl status dhcpd4.service
>>> ● dhcpd4.service - IPv4 DHCP server
>>> Loaded: loaded (/usr/lib/systemd/system/dhcpd4.service; enabled; vendor
>>> preset: disabled)
>>> Active: failed (Result: exit-code) since Thu 2017-10-12 17:09:38 CEST;
>>> 8s ago
>>> Process: 638 ExecStart=/usr/bin/dhcpd -4 -q -user dhcp -cf
>>> /etc/dhcpd.conf -pf /run/dhcpd4.pid (code=exited, status=1/FAILURE)
>>>
>>> Okt 12 17:09:38 server64 dhcpd[638]: If you think you have received this
>>> message due to a bug rather
>>> Okt 12 17:09:38 server64 dhcpd[638]: than a configuration issue please read
>>> the section on submitting
>>> Okt 12 17:09:38 server64 dhcpd[638]: bugs on either our web page at
>>> www.isc.org or in the README file
>>> Okt 12 17:09:38 server64 dhcpd[638]: before submitting a bug. These pages
>>> explain the proper
>>> Okt 12 17:09:38 server64 dhcpd[638]: process and the information we find
>>> helpful for debugging.
>>> Okt 12 17:09:38 server64 dhcpd[638]:
>>> Okt 12 17:09:38 server64 dhcpd[638]: exiting.
>>> Okt 12 17:09:38 server64 systemd[1]: dhcpd4.service: Control process
>>> exited, code=exited status=1
>>> Okt 12 17:09:38 server64 systemd[1]: dhcpd4.service: Failed with result
>>> 'exit-code'.
>>> Okt 12 17:09:38 server64 systemd[1]: Failed to start IPv4 DHCP server.
>>>
>>> journalctl -xe
>>> Okt 12 17:09:37 server64 systemd[1]: Starting IPv4 DHCP server...
>>> -- Subject: Unit dhcpd4.service has begun start-up
>>> -- Defined-By: systemd
>>> -- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
>>> --
>>> -- Unit dhcpd4.service has begun starting up.
>>> Okt 12 17:09:38 server64 dhcpd[638]: Internet Systems Consortium DHCP
>>> Server 4.3.6
>>> Okt 12 17:09:38 server64 dhcpd[638]: Copyright 2004-2017 Internet Systems
>>> Consortium.
>>> Okt 12 17:09:38 server64 dhcpd[638]: All rights reserved.
>>> Okt 12 17:09:38 server64 dhcpd[638]: For info, please visit
>>> https://www.isc.org/software/dhcp/
>>> Okt 12 17:09:38 server64 dhcpd[638]: Source compiled to use binary-leases
>>> Okt 12 17:09:38 server64 dhcpd[638]: Wrote 0 deleted host decls to leases
>>> file.
>>> Okt 12 17:09:38 server64 dhcpd[638]: Wrote 0 new dynamic host decls to
>>> leases file.
>>> Okt 12 17:09:38 server64 dhcpd[638]: Wrote 16 leases to leases file.
>>> Okt 12 17:09:38 server64 dhcpd[638]: Can't install packet filter program:
>>> Cannot allocate memory
>>> Okt 12 17:09:38 server64 dhcpd[638]:
>>> Okt 12 17:09:38 server64 dhcpd[638]: If you think you have received this
>>> message due to a bug rather
>>> Okt 12 17:09:38 server64 dhcpd[638]: than a configuration issue please read
>>> the section on submitting
>>> Okt 12 17:09:38 server64 dhcpd[638]: bugs on either our web page at
>>> www.isc.org or in the README file
>>> Okt 12 17:09:38 server64 dhcpd[638]: before submitting a bug. These pages
>>> explain the proper
>>> Okt 12 17:09:38 server64 dhcpd[638]: process and the information we find
>>> helpful for debugging.
>>> Okt 12 17:09:38 server64 dhcpd[638]:
>>> Okt 12 17:09:38 server64 dhcpd[638]: exiting.
>>> Okt 12 17:09:38 server64 systemd[1]: dhcpd4.service: Control process
>>> exited, code=exited status=1
>>> Okt 12 17:09:38 server64 systemd[1]: dhcpd4.service: Failed with result
>>> 'exit-code'.
>>> Okt 12 17:09:38 server64 systemd[1]: Failed to start IPv4 DHCP server.
>>> -- Subject: Unit dhcpd4.service has failed
>> pls try revert:
>> commit 02f7e4101092b88e57c73171174976c8a72a3eba
>
> Correction. The commit is:
>
> 345c66695569db83eed100723e4df72cb54df7de
>
> I will try the revert and let you know.
okay reverting the
commit 345c66695569db83eed100723e4df72cb54df7de
Author: Eric Dumazet <eduma...@google.com>
Date: Mon Oct 2 12:20:51 2017 -0700
socket, bpf: fix possible use after free
[ Upstream commit eefca20eb20c66b06cf5ed09b49b1a7caaa27b7b ]
Starting from linux-4.4, 3WHS no longer takes the listener lock.
Since this time, we might hit a use-after-free in sk_filter_charge(),
if the filter we got in the memcpy() of the listener content
just happened to be replaced by a thread changing listener BPF filter.
To fix this, we need to make sure the filter refcount is not already
zero before incrementing it again.
Fixes: e994b2f0fb92 ("tcp: do not lock listener to process SYN packets")
Signed-off-by: Eric Dumazet <eduma...@google.com>
Acked-by: Alexei Starovoitov <a...@kernel.org>
Acked-by: Daniel Borkmann <dan...@iogearbox.net>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
fixes the issue. Looks like this is a fix for another problem.
Anyway - I have 4.9.55 - minus 345c66695569db83eed100723e4df72cb54df7de
running now with networking operational.
thanks,
-- Shuah
