David Howells <[EMAIL PROTECTED]> writes:
> John Anthony Kazos Jr. <[EMAIL PROTECTED]> wrote:
>
>> if (veryverylengthycondition1
>> && smallcond2
>> && (conditionnumber3a
>> || condition3b)) {
>> ...
>> }
>>
>> Clear, crisp, and 80-wide. I also like how the logical operator on the
>> following line is indented slightly into the condition of the previous
>> line.
>
> The brain works better when associated things are lined up, so:
>
> if (veryverylengthycondition1 &&
> smallcond2 &&
> (conditionnumber3a ||
> condition3b)) {
>
> is better as it gives a visual clue to association.
Not lining up with the code following the if statement is also
a plus. Because it clearly delineates the conditions from the code.
Of course in many cases conditions this complex are candidates for
if (!condition1)
continue;
if (!condition2)
continue;
if (!condition3a && !condition3b)
continue;
Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
