Re: [PATCH V2 2/4] perf/x86/intel/uncore: inline function to check the fixed counter event

[Thomas Gleixner]

On Thu, 19 Oct 2017, kan.li...@intel.com wrote:
> From: Kan Liang <kan.li...@intel.com>
> 
> Remove the special codes in generic uncore_perf_event_update.

What are special codes?

> Introduce inline function to check the fixed counter event.
>  
> +static inline bool uncore_pmc_fixed(int idx)
> +{
> +     return (idx == UNCORE_PMC_IDX_FIXED);

The parentheses are pointless. Please get rid of them.

Thanks,

        tglx