On 10/27/2017 12:14 PM, Yisheng Xie wrote: > We have already checked whether maxnode is a page worth of bits, by: > maxnode > PAGE_SIZE*BITS_PER_BYTE > > So no need to check it once more. > > Signed-off-by: Yisheng Xie <[email protected]>
Acked-by: Vlastimil Babka <[email protected]> > --- > mm/mempolicy.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 613e9d0..3b51bb3 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1280,8 +1280,6 @@ static int get_nodes(nodemask_t *nodes, const unsigned > long __user *nmask, > /* When the user specified more nodes than supported just check > if the non supported part is all zero. */ > if (nlongs > BITS_TO_LONGS(MAX_NUMNODES)) { > - if (nlongs > PAGE_SIZE/sizeof(long)) > - return -EINVAL; > for (k = BITS_TO_LONGS(MAX_NUMNODES); k < nlongs; k++) { > unsigned long t; > if (get_user(t, nmask + k)) >
