On Thu, Nov 02, 2017 at 12:07:13PM +0100, Thomas Gleixner wrote: > On Thu, 2 Nov 2017, Ingo Molnar wrote: > > > * Ricardo Neri <[email protected]> wrote: > > > > > + /* > > > + * -EDOM means that we must ignore the address_offset. In such a case, > > > + * in 64-bit mode the effective address relative to the RIP of the > > > + * following instruction. > > > + */ > > > + if (*regoff == -EDOM) { > > > + if (user_64bit_mode(regs)) > > > + tmp = (long)regs->ip + insn->length; > > > + else > > > + tmp = 0; > > > + } else if (*regoff < 0) { > > > + return -EINVAL; > > > + } else { > > > + tmp = (long)regs_get_register(regs, *regoff); > > > + } > > > > > + else > > > + indx = (long)regs_get_register(regs, indx_offset); > > > > This and subsequent patches include a disgustly insane amount of type casts > > - why? > > > > For example here 'tmp' is 'long', while regs_get_register() returns > > 'unsigned long', but no type cast is necessary for that. > > > > > + ret = get_eff_addr_modrm(insn, regs, &addr_offset, > > > + &eff_addr); > > > > Also, please don't break lines slightly longer than 80 cols just to pacify > > checkpatch (and this holds for other patches as well) - the cure is worse > > than the > > illness! > > The right thing to do here is to split out stuff into a helper function > which removes the indentation levels or restructure the code to avoid them.
This patch introduce this several helper function. Perhaps I can add some more. For this particular case, I think that using shorter variable names will avoid this problem. Thanks and BR, Ricardo
