Split the error between devm_kzalloc and
devm_input_allocate_device, there is no need to call the second
allocator if the first has failed. Besides this doesn't provide
practical advantages.

CC: Michael Hennerich <michael.henner...@analog.com>
Signed-off-by: Andi Shyti <a...@etezian.org>
---
 drivers/input/touchscreen/ad7877.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/touchscreen/ad7877.c 
b/drivers/input/touchscreen/ad7877.c
index cf59e569d890..98deffde3fe2 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -710,6 +710,9 @@ static int ad7877_probe(struct spi_device *spi)
        }
 
        ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL);
+       if (!ts)
+               return -ENOMEM;
+
        input_dev = devm_input_allocate_device(&spi->dev);
        if (!input_dev)
                return -ENOMEM;
-- 
2.15.0

Reply via email to