Em Mon, Nov 13, 2017 at 10:11:58AM +0100, Jiri Olsa escreveu: > On Thu, Nov 09, 2017 at 06:55:26AM -0800, Andi Kleen wrote: > > From: Andi Kleen <a...@linux.intel.com> > > > > When using leader sampling the values of the not sampled but counted > > events are shown by perf script in "period". > > > > Currently printing period is only allowed when the main event > > has a period, that is it is in frequency mode. > > > > This implies that we cannot dump the values of counted events > > when the leader event is not in frequency mode. > > > > Just remove the check that the period must be set on all > > events. It will just be printed as 0 instead if it's not > > available. > > it'll be the value of configured period, not 0 > > int perf_evsel__parse_sample(struct ... > ... > data->period = evsel->attr.sample_period; > > $ perf record -c 100000 > $ perf script -F event,period | head -3 > Failed to open /tmp/perf-2048.map, continuing without symbols > 100000 cycles:ppp: > 100000 cycles:ppp: > > > other than that I think we can remove that check, > because we will have always sane number in period > > Acked-by: Jiri Olsa <jo...@kernel.org>
Applied, after adding your comments. - Arnaldo
