Hi Rob, > Am 15.11.2017 um 21:08 schrieb Rob Herring <[email protected]>: > > On Sun, Nov 12, 2017 at 09:59:55PM +0100, H. Nikolaus Schaller wrote: >> add bindings documentation for Wi2Wi W2SG00x4 GPS module > > Add ... module.
Ok. > >> >> Signed-off-by: H. Nikolaus Schaller <[email protected]> >> --- >> .../devicetree/bindings/misc/wi2wi,w2sg0004.txt | 24 >> ++++++++++++++++++++++ > > The path doesn't have to match the kernel. Use bindings/gps/... Ok. > >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt >> >> diff --git a/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt >> b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt >> new file mode 100644 >> index 000000000000..ccec9361a1a4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/misc/wi2wi,w2sg0004.txt >> @@ -0,0 +1,24 @@ >> +Wi2Wi GPS module connected through UART >> + >> +Should be a subnode of the SoC UART it is connected to (serdev). > > Could be connected to any kind of UART and serdev is a Linuxism. > > With those fixed, > > Acked-by: Rob Herring <[email protected]> Fine and thanks, Nikolaus Schaller PS: there is already a [PATCH v3] (no changes for 1/5 and 2/5)
