On Thu 16-11-17 14:17:43, Michal Hocko wrote:
> This seems familiar. Ohh, you have posted it
> http://lkml.kernel.org/r/20171021165032.20542-1-clabbe.montj...@gmail.com
> already. It fall though cracks, it seems. CCing Andrew
now, for real
> On Wed 15-11-17 19:27:09, Corentin Labbe wrote:
> > This patch fix the following build warning by simply removing the unused
> > info variable.
> > mm/shmem.c:3205:27: warning: variable 'info' set but not used
> > [-Wunused-but-set-variable]
> >
> > Signed-off-by: Corentin Labbe <cla...@baylibre.com>
>
> Acked-by: Michal Hocko <mho...@suse.com>
>
> > ---
> > mm/shmem.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/mm/shmem.c b/mm/shmem.c
> > index 544c105d706a..7fbe67be86fa 100644
> > --- a/mm/shmem.c
> > +++ b/mm/shmem.c
> > @@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct
> > dentry *dentry, const char *s
> > int len;
> > struct inode *inode;
> > struct page *page;
> > - struct shmem_inode_info *info;
> >
> > len = strlen(symname) + 1;
> > if (len > PAGE_SIZE)
> > @@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct
> > dentry *dentry, const char *s
> > error = 0;
> > }
> >
> > - info = SHMEM_I(inode);
> > inode->i_size = len-1;
> > if (len <= SHORT_SYMLINK_LEN) {
> > inode->i_link = kmemdup(symname, len, GFP_KERNEL);
> > --
> > 2.13.6
>
> --
> Michal Hocko
> SUSE Labs
--
Michal Hocko
SUSE Labs
