platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
              return irq instead of -ENODEV.
changes in v3 :
              Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/misc/twl4030-pwrbutton.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/input/misc/twl4030-pwrbutton.c 
b/drivers/input/misc/twl4030-pwrbutton.c
index b307cca..0dcf311 100644
--- a/drivers/input/misc/twl4030-pwrbutton.c
+++ b/drivers/input/misc/twl4030-pwrbutton.c
@@ -58,6 +58,9 @@ static int twl4030_pwrbutton_probe(struct platform_device 
*pdev)
        int irq = platform_get_irq(pdev, 0);
        int err;
 
+       if (irq <= 0)
+               return irq;
+
        pwr = devm_input_allocate_device(&pdev->dev);
        if (!pwr) {
                dev_err(&pdev->dev, "Can't allocate power button\n");
-- 
2.7.4

Reply via email to