platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
              ts->irq is unsigned. used int irq variable.
changes in v3 :
              Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

 drivers/input/touchscreen/sun4i-ts.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/sun4i-ts.c 
b/drivers/input/touchscreen/sun4i-ts.c
index d2e14d9..315f26b 100644
--- a/drivers/input/touchscreen/sun4i-ts.c
+++ b/drivers/input/touchscreen/sun4i-ts.c
@@ -251,6 +251,7 @@ static int sun4i_ts_probe(struct platform_device *pdev)
        bool ts_attached;
        u32 tp_sensitive_adjust = 15;
        u32 filter_type = 1;
+       int irq;
 
        ts = devm_kzalloc(dev, sizeof(struct sun4i_ts_data), GFP_KERNEL);
        if (!ts)
@@ -314,7 +315,10 @@ static int sun4i_ts_probe(struct platform_device *pdev)
        if (IS_ERR(ts->base))
                return PTR_ERR(ts->base);
 
-       ts->irq = platform_get_irq(pdev, 0);
+       irq = platform_get_irq(pdev, 0);
+       if (irq <= 0)
+               return irq;
+       ts->irq = irq;
        error = devm_request_irq(dev, ts->irq, sun4i_ts_irq, 0, "sun4i-ts", ts);
        if (error)
                return error;
-- 
2.7.4

Reply via email to