Hi,

On 26.11.2017 10:27, Takashi Sakamoto wrote:
> Hi,
> 
(..)
> Before applying this patch:
> 166         /* FIXME: the following three formats are not defined properly 
> yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> 170         [SNDRV_PCM_FORMAT_GSM] = {
> 171                 .le = -1, .signd = -1,
> 172         },
> 173         [SNDRV_PCM_FORMAT_SPECIAL] = {
> 174                 .le = -1, .signd = -1,
> 175         },
> 
> After applying this patch:
> 
> 166         /* FIXME: the following three formats are not defined properly 
> yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> 170         [SNDRV_PCM_FORMAT_GSM] = {
> 171                 .le = -1, .signd = -1,
> 172         },
> 173         [SNDRV_PCM_FORMAT_S20_LE] = {
(..)> 
> I think it good to add an alternative comment for each of entry which is not 
> defined yet, like:
> 
> -> 166         /* FIXME: this format is not defined properly yet */
> 167         [SNDRV_PCM_FORMAT_MPEG] = {
> 168                 .le = -1, .signd = -1,
> 169         },
> -> 170         /* FIXME: this format is not defined properly yet */
> 171         [SNDRV_PCM_FORMAT_GSM] = {
> 172                 .le = -1, .signd = -1,
> 173         },
> 174         [SNDRV_PCM_FORMAT_S20_LE] = {
> 175                 .width = 20, .phys = 32, .le = 1, .signd = 1,
> 176                 .silence = {},
> 177         },
> 178         [SNDRV_PCM_FORMAT_S20_BE] = {
> 179                 .width = 20, .phys = 32, .le = 0, .signd = 1,
> 180                 .silence = {},
> 181         },
> 182         [SNDRV_PCM_FORMAT_U20_LE] = {
> 183                 .width = 20, .phys = 32, .le = 1, .signd = 0,
> 184                 .silence = { 0x00, 0x00, 0x08, 0x00 },
> 185         },
> 186         [SNDRV_PCM_FORMAT_U20_BE] = {
> 187                 .width = 20, .phys = 32, .le = 0, .signd = 0,
> 188                 .silence = { 0x00, 0x08, 0x00, 0x00 },
> 189         },
> -> 190         /* FIXME: this format is not defined properly yet */
> 191         [SNDRV_PCM_FORMAT_SPECIAL] = {
> 192                 .le = -1, .signd = -1,
> 193         },
> 

Thanks, fixed now in v3.

> Regards
> 
> Takashi Sakamoto

Best regards,
Maciej Szmigiero

Reply via email to