On 12/03/2017 02:49 PM, Jacek Anaszewski wrote:
> Hi Dan,
>
> Thanks for the patch.
>
> On 12/01/2017 05:56 PM, Dan Murphy wrote:
>> Update the lp8860 dt binding to the LED standard where
>> the LED should have a child node and also adding a
>> LED trigger entry.
>>
>> Signed-off-by: Dan Murphy <[email protected]>
>> ---
>>
>> v6 - New patch to fix binding documentation
>>
>> Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----
>> 1 file changed, 11 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index aad38dd94d4b..4cf396de6eba 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -12,17 +12,24 @@ Required properties:
>> - label - Used for naming LEDs
>>
>> Optional properties:
>> - - enable-gpio - gpio pin to enable/disable the device.
>> - - supply - "vled" - LED supply
>> + - enable-gpios : gpio pin to enable/disable the device.
>> + - vled-supply : LED supply
>> + - label : see Documentation/devicetree/bindings/leds/common.txt
>> + - linux,default-trigger : (optional)
>> + see Documentation/devicetree/bindings/leds/common.txt
>
> Related driver doesn't parse this DT property AFAICS.
Ah, I missed that you're adding it in 5/6.
>
>> Example:
>>
>> -leds: leds@6 {
>> +lp8860@2d {
>> compatible = "ti,lp8860";
>> reg = <0x2d>;
>> - label = "display_cluster";
>> enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>
> s/gpio/gpios/
>
>> vled-supply = <&vbatt>;
>> +
>> + backlight: backlight@0 {
>> + label = "backlight_cluster";
>> + linux,default-trigger = "backlight";
>> + };
>> }
>>
>> For more product information please see the link below:
>>
>
