Yixun Lan <yixun....@amlogic.com> writes: > From: Qiufang Dai <qiufang....@amlogic.com> > > Try to add Hiubus DT info, and also enable clock DT info > for the Amlogic's Meson-AXG SoC. > > Acked-by: Rob Herring <r...@kernel.org> > Signed-off-by: Qiufang Dai <qiufang....@amlogic.com> > Signed-off-by: Yixun Lan <yixun....@amlogic.com> > --- > arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > index b932a784b02a..36a2e98338a8 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi > @@ -7,6 +7,7 @@ > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/clock/axg-clkc.h>
This #include will cause an unnessary dependency from the amlogic tree to the clock tree even though this patch is not currently using any of the #defines from that header. It will simplify the dependencies if you drop this #include from this patch. In my comment on the cover letter, I suggested adding a patch that also switches the UART over to the new clock provider. That is the patch that should add this #include, since it will actually need #defines from the header. Doing it in that order means that we could merge this patch independently of the clock driver, and then merge the UART switch-over patch only after the driver (and headers) are merged. Kevin
