On Tue, 5 Dec 2017, Tomasz Kramkowski wrote: > On Mon, Dec 04, 2017 at 08:55:50PM +0000, Tomasz Kramkowski wrote: > > +static void mouse_button_fixup(struct hid_device *hdev, > > + __u8 *rdesc, unsigned int *rsize, > > + int nbuttons) > > I've just remembered what has been bugging me yesterday when I was > reviewing this patch. I had come to the realisation (and then > subsequently forgotten) that this function should probably return __u8 * > and also get assigned to rdesc on the other end. It seems to me that it > makes most sense to allow for the possibility (although slim) of this > function eventually being expanded to actually replace the report > descriptor
Sure, but you can extend the API of mouse_button_fixup() once such need arises; no need to pass data pointers around without having actual use for them. -- Jiri Kosina SUSE Labs
