* [email protected] <[email protected]> wrote: > From: Mengting Zhang <[email protected]> > > An annoying compile warning due to missing declaration is shown below: > In file included from lockdep.c:27:0: > ../../../kernel/locking/lockdep.c: In function 'print_unlock_imbalance_bug' : > ../../../kernel/locking/lockdep.c:3544:2: warning: implicit declaration of > function 'pr_cont' [-Wimplicit-function-declaration] > pr_cont(") at:\n"); > ^
All build warnings are annoying, please formulate this in a more neutral fashion. Also, please separate the compiler splat from the changelog text with an empty line, and align it vertically as well so that it seprates more. Please do this for the second patch as well, and try to harmonize the style of the changelogs. This is an example of a clean changelog that fixes a build warning: commit 1b3b5219abfd6a214e99018747e9fe98514b43ca Author: Arnaldo Carvalho de Melo <[email protected]> Date: Mon Nov 27 12:18:23 2017 -0300 tools headers: Syncronize mman.h ABI header To add support for the MAP_SYNC flag introduced in: b6fb293f2497 ("mm: Define MAP_SYNC and VM_SYNC flags") Update tools/perf/trace/beauty/mmap.c to support that flag. This silences this perf build warning: Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/mman.h' differs from latest version at 'include/uapi/asm-generic/mman.h' Cc: Adrian Hunter <[email protected]> Cc: Dan Williams <[email protected]> Cc: David Ahern <[email protected]> Cc: Jan Kara <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Wang Nan <[email protected]> Link: https://lkml.kernel.org/n/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> Thanks, Ingo
