On Thu, Dec 07, 2017 at 02:53:29PM -0500, David Miller wrote: > From: Antoine Tenart <antoine.ten...@free-electrons.com> > Date: Thu, 7 Dec 2017 09:48:58 +0100 > > > This patch adds a check to only free the TSO header buffer when its > > allocation previously succeeded. > > > > Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> > > No, please keep this as a failure to bring up. > > Even if you emit a log message, it is completely unintuitive to > have netdev features change on the user just because of a memory > allocation failure.
One thing I forgot, this patch still is needed for a proper error path handling. We can't be sure all buffers were allocated correctly when calling mvpp2_txq_deinit() (e.g. if one of them was the reason of the fail). I'll send a v2 without the patch 2/6, but I'll keep this one. Thanks, Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
