Hi Rob, Thanks a lot for the review.
> -----Original Message----- > From: Rob Herring [mailto:[email protected]] > Sent: Tuesday, December 12, 2017 12:07 PM > To: Dhaval Rajeshbhai Shah <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; Hyun Kwon <[email protected]>; Dhaval > Rajeshbhai Shah <[email protected]> > Subject: Re: [PATCH v2 1/2] Documentation: devicetree: Add DT bindings to > xlnx_vcu driver > > On Thu, Dec 07, 2017 at 01:31:15PM -0800, Dhaval Shah wrote: > > Add Device Tree binding document for logicoreIP. This logicoreIP > > provides the isolation between the processing system and programmable > > logic. Also provides the clock related information. > > > > Signed-off-by: Dhaval Shah <[email protected]> > > --- > > Changes since v2: > > * Describe the h/w > > * compatible string is updated to make it more specific > > based on the logicoreIP version. > > * Removed that encoder and decoder child nodes and relatd properties as > that > > will be a separate driver and dts nodes. other team is working on that. > > * Updated to use as a single driver. > > > > .../devicetree/bindings/misc/xlnx,vcu.txt | 31 > ++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/misc/xlnx,vcu.txt > > Reviewed-by: Rob Herring <[email protected]> > > One nit. Use "dt-bindings: misc: ..." for the subject. I will update subject line and send you v3 patch set.
