On Mon, Dec 18, 2017 at 10:55:02AM -0700, Jason Gunthorpe wrote: > On Mon, Dec 18, 2017 at 01:29:01PM +0100, Javier Martinez Canillas wrote: > > On 12/18/2017 01:22 PM, Javier Martinez Canillas wrote: > > > > [snip] > > > > > > > > James, > > > > > > Can you please test the following (untested) patch on top of the other two > > > mentioned patches to see if it makes a difference for you? > > > > > > > I should had tried to at least compile the patch :) > > I think this is backwards.. > > If CLKRUN_EN is on (eg power management is NOT enabled on LPC) then > TPM shouldn't do anything at all. > > If CLKRUN_EN is off, then it should try to turn it on/off to save > power. > > Perhaps the best work around is to just delete the turning off of > CLKRUN_EN ? Uses more power but keeps the clock running which should > keep both TPM and superio happy. > > Jason
On some BSW systems keeping CLKRUN_EN on during TPM command caused issues. That was the original reason for the fixes. /Jarkko
