On Tue, Aug 08, 2017 at 06:56:37PM +0300, Anton Vasilyev wrote: > Debugfs file reset_stats is created with S_IRUSR permissions, > but ocrdma_dbgfs_ops_read() doesn't support OCRDMA_RESET_STATS, > whereas ocrdma_dbgfs_ops_write() supports only OCRDMA_RESET_STATS. > > The patch fixes misstype with permissions. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Anton Vasilyev <[email protected]> > Acked-by: Selvin Xavier <[email protected]> > drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c > b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c > index 66056f9..d42c617 100644 > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c > @@ -834,7 +834,7 @@ void ocrdma_add_port_stats(struct ocrdma_dev *dev) > > dev->reset_stats.type = OCRDMA_RESET_STATS; > dev->reset_stats.dev = dev; > - if (!debugfs_create_file("reset_stats", S_IRUSR, dev->dir, > + if (!debugfs_create_file("reset_stats", S_IWUSR, dev->dir, > &dev->reset_stats, &ocrdma_dbg_ops)) > goto err; >
I changed the S_IWUSR to 0200 to make checkpatch happy, slowly we are trying to move to the standard style throughout, but applied to for-next now. Thanks, Jason
