On 22-Dec 13:19, Peter Zijlstra wrote: > On Fri, Dec 22, 2017 at 12:07:37PM +0000, Patrick Bellasi wrote: > > > I was thinking that since dl is a 'global' scheduler the reservation > > > would be too and thus the freq just needs a single CPU to be observed; > > > > AFAIU global is only the admission control (which is something worth a > > thread by itself...) while the dl_se->dl_bw are aggregated into the > > dl_rq->running_bw, which ultimately represents the DL bandwidth > > required for just a CPU. > > Oh urgh yes, forgot that.. then the dl freq stuff isn't strictly correct > I think. But yes, that's another thread.
Mmm... maybe I don't get your point... I was referring to the global admission control of DL. If you have for example 3 60% DL tasks on a 2CPU system, AFAIU the CBS will allow the tasks in the system (since the overall utilization is 180 < 200 * 0.95) although that workload is not necessarily schedule (for example if the tasks wakeups at the same time one of them will miss its deadline). But, yeah... maybe I'm completely wrong or, in any case, it's for a different thread... > > > but I suppose there's nothing stopping anybody from splitting a clock > > > domain down the middle scheduling wise. So yes, good point. > > > > That makes sense... moreover, using the global utilization, we would > > end up asking for capacities which cannot be provided by a single CPU. > > Yes, but that _should_ not be a problem if you clock them all high > enough. But this gets to be complicated real fast I think. IMO the current solution with Juri's patches is working as expected: we know how many DL tasks are runnable on a CPU and we properly account for their utilization. The only "issue/limitation" is (eventually) the case described above. Dunno if we can enqueue 2 60% DL tasks on the same CPU... in that case we will ask for 120% Utilization? > > > Blergh that'd make a mess of things again. > > > > Actually, looking better at your patch: are we not just ok with that? > > > > I mean, we don't need this check on idle_cpu since in > > sugov_aggregate_util we already skip the util=sg_cpu->max in case of > > !rq->rt.rt_nr_running, while we aggregate just CFS and DL requests. > > Right, well, I don't actually have an environment to test this sanely, > so someone will have to go play with the various variations and see what > works. Definitively, we have some synthetics for mainline... as well as we can easily backport this series to v4.9 and test for power/perf using a full Android stack. But, give today is the 22th, I guess we can do that after holidays (in ~2 weeks). -- #include <best/regards.h> Patrick Bellasi
