Hi Geert, I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next] [also build test ERROR on v4.15-rc6 next-20180103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/of-fdt-Fix-ifdef-dependency-of-early-flattree-declarations/20180104-062259 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: i386-randconfig-i0-201800 (attached as .config) compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/tty/serial/earlycon.c: In function 'param_setup_earlycon': >> drivers/tty/serial/earlycon.c:221:11: error: implicit declaration of >> function 'early_init_dt_scan_chosen_stdout' >> [-Werror=implicit-function-declaration] return early_init_dt_scan_chosen_stdout(); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/early_init_dt_scan_chosen_stdout +221 drivers/tty/serial/earlycon.c ad1696f6f Aleksey Makarov 2016-09-27 206 470ca0de6 Peter Hurley 2015-03-09 207 /* early_param wrapper for setup_earlycon() */ 470ca0de6 Peter Hurley 2015-03-09 208 static int __init param_setup_earlycon(char *buf) 470ca0de6 Peter Hurley 2015-03-09 209 { 470ca0de6 Peter Hurley 2015-03-09 210 int err; 470ca0de6 Peter Hurley 2015-03-09 211 470ca0de6 Peter Hurley 2015-03-09 212 /* 470ca0de6 Peter Hurley 2015-03-09 213 * Just 'earlycon' is a valid param for devicetree earlycons; 470ca0de6 Peter Hurley 2015-03-09 214 * don't generate a warning from parse_early_params() in that case 470ca0de6 Peter Hurley 2015-03-09 215 */ ad1696f6f Aleksey Makarov 2016-09-27 216 if (!buf || !buf[0]) { ad1696f6f Aleksey Makarov 2016-09-27 217 if (IS_ENABLED(CONFIG_ACPI_SPCR_TABLE)) { ad1696f6f Aleksey Makarov 2016-09-27 218 earlycon_init_is_deferred = true; ad1696f6f Aleksey Makarov 2016-09-27 219 return 0; 447ef990a Jeffy Chen 2017-08-19 220 } else if (!buf) { d503187b6 Leif Lindholm 2016-09-27 @221 return early_init_dt_scan_chosen_stdout(); ad1696f6f Aleksey Makarov 2016-09-27 222 } ad1696f6f Aleksey Makarov 2016-09-27 223 } 470ca0de6 Peter Hurley 2015-03-09 224 470ca0de6 Peter Hurley 2015-03-09 225 err = setup_earlycon(buf); 66c53aaa9 Peter Hurley 2015-05-07 226 if (err == -ENOENT || err == -EALREADY) 66c53aaa9 Peter Hurley 2015-05-07 227 return 0; 470ca0de6 Peter Hurley 2015-03-09 228 return err; 7c53cb3de Peter Hurley 2015-03-09 229 } 470ca0de6 Peter Hurley 2015-03-09 230 early_param("earlycon", param_setup_earlycon); 7c53cb3de Peter Hurley 2015-03-09 231 :::::: The code at line 221 was first introduced by commit :::::: d503187b6cc4e41c21c02e695e0e7b5acdd066de of/serial: move earlycon early_param handling to serial :::::: TO: Leif Lindholm <[email protected]> :::::: CC: Greg Kroah-Hartman <[email protected]> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
