On Wed, Jan 10, 2018 at 2:42 AM, Viresh Kumar <viresh.ku...@linaro.org> wrote: > On 10-01-18, 09:08, Greg Kroah-Hartman wrote: >> On Wed, Jan 10, 2018 at 09:14:40AM +0530, Viresh Kumar wrote: >> > On 09-01-18, 19:47, Greg Kroah-Hartman wrote: >> > > Can you resend this? As you can tell, I've been a bit busy for the past >> > > month or so :( >> > >> > Sure. >> > >> > > Also, why is there no signed-off-by on the OF core patches? >> > >> > A bit confused, sorry. Are you looking for my signed-off ? They are already >> > there. >> > >> > Or are you looking for Rob's (OF maintainer) signed-off ? >> >> Looking for Rob's, why hasn't he reviewed this yet?
I did review the whole series on version v4... The whole thing seems pretty hacky to me. OTOH, I don't know if there's an elegant solution to this problem. This also tries to be a general solution for what's largely an earlycon (which is, news flash, a debug tool) and displays for which we already address at least some of this with simplefb (not that it is a great solution either). I've yet to hear of any other concrete uses for this. > He went through them for sure but never gave his Ack. I have asked him to > provide Acks for the first 2 patches this morning, if they look fine to him. The drivers/of/ changes on their own are innocent enough if there's a reason (We generally want users using of_platform_populate rather than of_platform_bus_create, so that's why it's not exported now.). It's really all the rest that concerns me. Rob