> -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.anders...@linaro.org] > Sent: Thursday, December 14, 2017 6:35 AM > To: Loic PALLARDY <loic.palla...@st.com> > Cc: o...@wizery.com; linux-remotep...@vger.kernel.org; linux- > ker...@vger.kernel.org; Arnaud POULIQUEN <arnaud.pouliq...@st.com>; > benjamin.gaign...@linaro.org > Subject: Re: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout > by name for carveout allocation > > On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote: > > + /* By name */ > > + mem = rproc_find_carveout_by_name(rproc, rsc->name); > > + if (mem) { > > + /* > > + * Update resource table with registered carevout > information > > + */ > > + rsc->len = mem->len; > > You should validate that len, da and pa are compatible. Yes you're right, complete definition must be checked
Regards, Loic > > > + rsc->da = mem->da; > > + rsc->pa = rproc_va_to_pa(mem->va); > > + /* no need to register as already match one for one */ > > + return 0; > > + } > > Regards, > Bjorn
