On Fri, Nov 17, 2017 at 03:51:31PM +0100, Philippe Ombredanne wrote: > On Fri, Nov 17, 2017 at 3:17 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string. > > > > This allows tools that check that the module license matches the source > > code license to work properly, as there is no need to unwind the > > unneeded dereference. For some of these drivers, the #define is just a > > few lines above the MODULE_LICENSE() line, which is extra pointless. > > > > Cc: Dmitry Torokhov <dmitry.torok...@gmail.com> > > Cc: Arvind Yadav <arvind.yadav...@gmail.com> > > Reported-by: Philippe Ombredanne <pombreda...@nexb.com> > > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > > Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com>
Applied, thank you. -- Dmitry
