On Fri, Jan 19, 2018 at 02:26:20PM -0800, Randy Dunlap wrote:
> On 01/19/2018 11:41 AM, Dmitry Torokhov wrote:
> > Let's explicitly document bit numbers with BIT() macro.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com>
>
> Makes sense, but something should
> #include <linux/bitops.h>
Indeed, I'll add it, thanks.
>
> per Documentation/process/submit-checklist.rst Rule #1:
> 1) If you use a facility then #include the file that defines/declares
> that facility. Don't depend on other header files pulling in ones
> that you use.
>
>
> > ---
> > include/linux/libps2.h | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/linux/libps2.h b/include/linux/libps2.h
> > index 365c50b097ded..649295a5ff47d 100644
> > --- a/include/linux/libps2.h
> > +++ b/include/linux/libps2.h
> > @@ -20,11 +20,11 @@
> > #define PS2_RET_NAK 0xfe
> > #define PS2_RET_ERR 0xfc
> >
> > -#define PS2_FLAG_ACK 1 /* Waiting for ACK/NAK */
> > -#define PS2_FLAG_CMD 2 /* Waiting for command to
> > finish */
> > -#define PS2_FLAG_CMD1 4 /* Waiting for the first byte
> > of command response */
> > -#define PS2_FLAG_WAITID 8 /* Command execiting is GET ID
> > */
> > -#define PS2_FLAG_NAK 16 /* Last transmission was NAKed
> > */
> > +#define PS2_FLAG_ACK BIT(0) /* Waiting for ACK/NAK */
> > +#define PS2_FLAG_CMD BIT(1) /* Waiting for a command to
> > finish */
> > +#define PS2_FLAG_CMD1 BIT(2) /* Waiting for the first byte
> > of command response */
> > +#define PS2_FLAG_WAITID BIT(3) /* Command executing is GET ID
> > */
> > +#define PS2_FLAG_NAK BIT(4) /* Last transmission was NAKed
> > */
> >
> > struct ps2dev {
> > struct serio *serio;
> >
>
>
> --
> ~Randy
--
Dmitry
