On Thu, 2018-01-25 at 10:29 +0800, Wang, Haiyue wrote: > > On 2018-01-23 16:44, Greg KH wrote: > > On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote:
> > > + depends on ARCH_ASPEED || COMPILE_TEST > > > + select REGMAP_MMIO > > > > Select or depend? > > Before, I used "depends on". I was told to to change "select". I'm > not > sure which is more better by practice ? git grep will answer to this question, but also documentation is good to read. REGMAP API is selected by users. One case where it's not so looks like a bug. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy