On Wed, Jan 31, 2018 at 12:03 PM, Jolly Shah <[email protected]> wrote: > Hi Rob, > Thanks for the review, > >> -----Original Message----- >> From: Rob Herring [mailto:[email protected]] >> Sent: Tuesday, January 30, 2018 9:08 AM >> To: Jolly Shah <[email protected]> >> Cc: [email protected]; [email protected]; >> [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; >> [email protected]; [email protected]; linux- >> [email protected]; [email protected]; Jolly Shah >> <[email protected]>; Rajan Vaja <[email protected]> >> Subject: Re: [PATCH v3 1/4] dt-bindings: firmware: Add bindings for ZynqMP >> firmware >> >> On Wed, Jan 24, 2018 at 03:21:11PM -0800, Jolly Shah wrote: >> > Add documentation to describe Xilinx ZynqMP firmware driver bindings. >> > Firmware driver provides an interface to firmware APIs. Interface APIs >> > can be used by any driver to communicate to PMUFW (Platform Management >> > Unit). >> > >> > Signed-off-by: Jolly Shah <[email protected]> >> > Signed-off-by: Rajan Vaja <[email protected]> >> > --- >> > .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt | 16 >> ++++++++++++++++ >> > 1 file changed, 16 insertions(+) >> > create mode 100644 >> > Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware >> > .txt >> > >> > diff --git >> > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmwa >> > re.txt >> > b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmwa >> > re.txt >> > new file mode 100644 >> > index 0000000..a7aaf56 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-fi >> > +++ rmware.txt >> > @@ -0,0 +1,16 @@ >> > +Xilinx Zynq MPSoC Firmware Device Tree Bindings >> > + >> > +The zynqmp-firmware node describes the interface to platform firmware. >> >> Please define this a is child of /firmware. >> > I dint get you. It is already under firmware/xilinx.
Put it under a "firmware" node in DT. See other firmware bindings for examples. Rob
