On Mon, 5 Feb 2018 15:50:48 +0000 Lina Iyer <[email protected]> wrote:
> >diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c > >index a392380eada6..7f177ad88713 100644 > >--- a/drivers/irqchip/qcom-pdc.c > >+++ b/drivers/irqchip/qcom-pdc.c > >@@ -26,6 +26,8 @@ > > #include <linux/platform_device.h> > > #include <linux/slab.h> > > #include <linux/types.h> > >+#define CREATE_TRACE_POINTS > >+#include "trace/events/pdc.h" > > > In addition to this PDC patch, there are a few drivers with FTRACE > support coming for up QCOM SoCs. Would it make sense to open up a new > sub-folder for SoC specific FTRACE like say, > trace/events/soc/ > trace/events/soc/qcom/ > > What would be your recommendation? > > At the very least, I am thinking of renaming this file to > trace/events/qcom-pdc.h. I'm thinking it makes more sense to create the trace.h file inside the drivers/irqchip/ directory. xfs does this, as well as other locations. The include/trace/events/ was more of a generic method, but when events start getting more specific, they should be in their own directories. See samples/trace_events/* on how to have the file locally (or look at xfs, search for trace in fs/xfs/Makefile). -- Steve
