On 05/02/18 02:14, Randy Dunlap wrote: > On 02/04/2018 03:03 PM, Matthew Wilcox wrote: >> On Sun, Feb 04, 2018 at 02:19:22PM -0800, Randy Dunlap wrote: >>>> +#ifndef __GENALLOC_SELFTEST_H__ >>>> +#define __GENALLOC_SELFTEST_H__ >>> >>> Please use _LINUX_GENALLOC_SELFTEST_H_ >> >> willy@bobo:~/kernel/linux$ git grep define.*_H__$ include/linux/*.h |wc -l >> 98 >> willy@bobo:~/kernel/linux$ git grep define.*_H_$ include/linux/*.h |wc -l >> 110 >> willy@bobo:~/kernel/linux$ git grep define.*_H$ include/linux/*.h |wc -l >> 885 >> >> No trailing underscore is 8x as common as one trailing underscore. > > OK, ack.
ok, I'll move to _LINUX_xxx_yyy_H format -- thanks, igor