On Tue, Feb 13, 2018 at 09:49:50AM -0800, Guenter Roeck wrote: > On Sun, Feb 11, 2018 at 10:21:05PM -0700, Jerry Hoemann wrote: > > Update Module Author and permission on parameters so that the > > parameters show up in sysfs. > > > > Does it really add value to see the module parameters in sysfs ? > You would get both in standardized form by enabling WATCHDOG_SYSFS.
Not as much value as it did before I knew about WATCHDOG_SYSFS. :) It might still offer some unit level debug insight. The majority of users of module_param are specifying read permissions, so there is a uniformity aspect to having it. But, not a big deal. I'll remove read permission change if you want me to. -- ----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett Packard Enterprise -----------------------------------------------------------------------------
