On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > _port_ is being used as index to array port_hwtstamp before verifying > it is a non-negative number and a valid index at line 209 and 258: > > if (port < 0 || port >= mv88e6xxx_num_ports(chip)) > > Fix this by checking _port_ before using it as index to array > port_hwtstamp.
NAK. Port is already known to be valid in the callers. See: *** net/dsa/slave.c: dsa_slave_ioctl[266] *** net/dsa/slave.c: dsa_skb_tx_timestamp[416] *** net/dsa/dsa.c: dsa_skb_defer_rx_timestamp[152] > Addresses-Coverity-ID: 1465287 ("Negative array index read") > Addresses-Coverity-ID: 1465291 ("Negative array index read") Please check the code before posting. These false positives are really annoying. Thanks, Richard