On Sun, 2018-02-18 at 13:58 +0100, Luc Van Oostenryck wrote: > On Fri, Feb 16, 2018 at 11:07:03PM +0200, Andy Shevchenko wrote: > > Sparse complains that constant is so bit for unsigned long on 64-bit > > architecture. > > > > lib/test_printf.c:217:54: warning: constant 0xffff0123456789ab is so > > big it is unsigned long > > lib/test_printf.c:246:54: warning: constant 0xffff0123456789ab is so > > big it is unsigned long > > > > To satisfy everyone, mark the constant with ULL. > > It should be 'UL' not 'ULL' since for architectures a pointer and > a unsigned long have the ame size while on 32bit archs, long long > are (or may?) 64bit.
Yes, UL works as well. Andrew, tell me if I need to send an update (followup) or a new version. Btw, I ran test_printf suite on both 32- and 64-bit code, everything passed. So, if anyone notices a regression, please, create a test case that we may run. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy
