On Wed, Feb 21, 2018 at 5:23 AM, Rob Herring <[email protected]> wrote: > On Tue, Feb 20, 2018 at 10:47 PM, Brendan Higgins > <[email protected]> wrote: >> On Mon, Feb 19, 2018 at 6:49 AM, Rob Herring <[email protected]> wrote: >>> On Thu, Feb 15, 2018 at 02:38:12PM -0800, Brendan Higgins wrote: >>>> On Thu, Feb 15, 2018 at 5:39 AM, Tali Perry <[email protected]> wrote: >>>> > >>>> > Signed-off-by: Tali Perry <[email protected]> >>>> > >>>> <snip> >>>> >>>> I think this should probably be rolled into [PATCH v2 1/1] npcm750: add >>>> fixed >>>> clocks (moved from drivers/clk/clk-npcm7xx.c): >>>> https://www.spinics.net/lists/arm-kernel/msg634678.html >>> >>> No, binding docs, dts files and driver code should all be separate >>> patches. >> >> My mistake. This patch has a dt-bindings include file; should the include >> file >> go in here, with the dtsi changes, or in its own separate patch? > > It defines the binding, so with the binding documentation. >
So two things, first off, the include file I was asking about is not a dtsi, but a file that defines a bunch of macros for referencing clocks. I don't know if that makes a difference. Second, the patch that I referenced above, "[PATCH v2 1/1] npcm750: add fixed clocks (moved from drivers/clk/clk-npcm7xx.c): https://www.spinics.net/lists/arm-kernel/msg634678.html", *does* contain a dtsi and nothing else, and defines these bindings, which is why I thought it went in with the binding docs. Cheers

