Hi,

The subject line should mention the R40, there are far too many sun8i SoCs.

On 25/02/18 13:51, hao_zhang wrote:
> This patch adds pwm node for sun8i.
> 
> Signed-off-by: hao_zhang <[email protected]>
> ---
>  arch/arm/boot/dts/sun8i-r40.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi 
> b/arch/arm/boot/dts/sun8i-r40.dtsi
> index 173dcc1..99a0261 100644
> --- a/arch/arm/boot/dts/sun8i-r40.dtsi
> +++ b/arch/arm/boot/dts/sun8i-r40.dtsi
> @@ -295,6 +295,11 @@
>                               bias-pull-up;
>                       };
>  
> +                     pwm_ch0_pin: pwm-ch0-pin {
> +                             pins = "PB2";
> +                             function = "pwm";
> +                     };
> +
>                       uart0_pb_pins: uart0-pb-pins {
>                               pins = "PB22", "PB23";
>                               function = "uart0";
> @@ -306,6 +311,14 @@
>                       reg = <0x01c20c90 0x10>;
>               };
>  
> +             pwm: pwm@1c23400 {
> +                          compatible = "allwinner,sun8i-r40-pwm";
> +                          reg = <0x01c23400 0x154>;

Following my comments on the binding document:
                        interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;

> +                          clocks = <&osc24M>;

And possibly multiple clocks here (though I fail to find the APB1 clock
being exposed by our CCU).

Cheers,
Andre.

> +                          #pwm-cells = <3>;
> +                          status = "disabled";
> +             };
> +
>               uart0: serial@1c28000 {
>                       compatible = "snps,dw-apb-uart";
>                       reg = <0x01c28000 0x400>;
> 

Reply via email to