Hi John, On Fri, Mar 2, 2018 at 9:35 PM, William Cohen <wco...@redhat.com> wrote: > On 03/02/2018 03:24 AM, John Garry wrote: >> On 27/02/2018 09:50, Jiri Olsa wrote: >>> On Sat, Feb 24, 2018 at 12:05:21AM +0800, John Garry wrote: >>>> This patchset adds support for some perf events features, >>>> targeted at ARM64, implemented in a generic fashion. >>>> >>>> The two main features are as follows: >>>> - support for arch/vendor/platform pmu events directory structure >>>> - to support this, topic subdirectory support needs to be dropped >>>> - support for parsing standard architecture pmu events >>>> >>>> On the back of these, the Cavium ThunderX2, ARM Cortex-A53, >>>> and HiSilicon hip08 JSONs are relocated/added/updated. >>>> >>>> In addition, there is a patch to drop mutli-mapfile.csv support and >>>> also a bugfix in jevents.c for an error code value. >>>> >>>> Differences to v1: >>>> - Address coding issues from Jiri Olsa in adding arch std event >>>> support (https://lkml.org/lkml/2018/2/6/501) >>>> - add patch to drop topic subdirectory support >>>> - add patch for bug fix in json_events() >>>> - add review tags from Jiri Olsa >>> >>> can't tell if those json file changes are ok, but for all the code changes: >>> >> >> Hi William, Ganapatrao, >> >> Can you check the modifications to the ARM64 JSONs you originally submitted >> in the patchset please?> >> If they are not checked, I'll have to see if the maintainers will accept >> without your review. If not, I'll have to drop them.
I am seeing issue(log below) with this patchset on our platfrom. i have tried using your v2 branch [1] root@borg-1>perf_acme>> ./perf --version perf version 4.16.rc1.g087f7ca root@borg-1>perf_acme>> ./perf stat -e bus_access_rd sleep 1 Performance counter stats for 'sleep 1': 23,099 bus_access_rd 1.000708516 seconds time elapsed root@borg-1>perf_acme>> cd - /ganapat/perf/linux-hisi/tools/perf root@borg-1>perf>> ./perf --version perf version 4.16.rc1.gcb5a74 root@borg-1>perf>> ./perf stat -e bus_access_rd sleep 1 Performance counter stats for 'sleep 1': 0 bus_access_rd 1.000709162 seconds time elapsed root@borg-1>perf>> [1] https://github.com/hisilicon/linux-hisi.git > > Hi John, > > I will take a look at the patches this weekend and give feedback beginning of > next week. -Will > >> >> Thanks, >> John >> >>> Acked-by: Jiri Olsa <jo...@kernel.org> >>> >>> thanks, >>> jirka >>> >>> . thanks Ganapat >>> >> >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel