From: Alexei Starovoitov <a...@fb.com>

[ Upstream commit 12a3cc8424fe1237aaeb982dec4f0914ddd22f3e ]

fix incorrect stack state prints in print_verifier_state()

Fixes: 638f5b90d460 ("bpf: reduce verifier memory consumption")
Signed-off-by: Alexei Starovoitov <a...@kernel.org>
Acked-by: John Fastabend <john.fastab...@gmail.com>
Acked-by: Daniel Borkmann <dan...@iogearbox.net>
Signed-off-by: Daniel Borkmann <dan...@iogearbox.net>
Signed-off-by: Sasha Levin <alexander.le...@microsoft.com>
---
 kernel/bpf/verifier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 13551e623501..51cb3f018606 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -279,7 +279,7 @@ static void print_verifier_state(struct bpf_verifier_env 
*env,
        for (i = 0; i < state->allocated_stack / BPF_REG_SIZE; i++) {
                if (state->stack[i].slot_type[0] == STACK_SPILL)
                        verbose(env, " fp%d=%s",
-                               -MAX_BPF_STACK + i * BPF_REG_SIZE,
+                               (-i - 1) * BPF_REG_SIZE,
                                reg_type_str[state->stack[i].spilled_ptr.type]);
        }
        verbose(env, "\n");
-- 
2.14.1

Reply via email to