On Monday 12 March 2018 04:15 PM, Avri Altman wrote: > >> -----Original Message----- >> From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] >> Sent: Monday, March 12, 2018 12:08 PM >> To: Harish Jenny K N <harish_kand...@mentor.com>; ulf.hans...@linaro.org; >> linus.wall...@linaro.org; adrian.hun...@intel.com; shawn.lin@rock- >> chips.com; Avri Altman <avri.alt...@wdc.com> >> Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; >> vladimir_zapols...@mentor.com >> Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs. >> >> On Mon, 2018-03-12 at 10:01 +0530, Harish Jenny K N wrote: >>> This patch exports the host capabilities to debugfs >>> >>> This idea of sharing host capabilities over debugfs came up from Abbas >>> Raza <abbas_r...@mentor.com> Earlier discussions: >>> https://lkml.org/lkml/2018/3/5/357 >>> https://www.spinics.net/lists/linux-mmc/msg48219.html >>> >> Address below minors and, FWIW, take mine >> >> Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> >> >>> + for_each_set_bit(bit, (const unsigned long *)&caps, >>> BITS_PER_LONG) >>> + for_each_set_bit(bit, (const unsigned long *)&caps2, >>> BITS_PER_LONG) >> Explicit casting is not needed anymore in both cases. > Also maybe use sizeof(mmc_host_capabilities) instead of BITS_PER_LONG?
You mean sizeof(caps) and not sizeof(mmc_host_capabilities) . Right ? Thanks, Harish Jenny K N
