Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices

[Jakob Unterwurzacher]

On 14.03.18 10:17, Wolfgang Grandegger wrote:
Counting the state changes is one thing but you should also generate 
error messages for them.

We do for BUS-OFF already (see below), but not for other states - will 
do in v3.

+       /* we switched into a worse state */
+       up->can.state = new_state;
+       switch (new_state) {
+       case CAN_STATE_BUS_OFF:
+               can_stats->bus_off++;
+               can_bus_off(up->netdev);
+               netdev_info(up->netdev,
+                           "link has gone into BUS-OFF state\n");
+               break;