Hi Andrew,

>filter_irq_stacks() is too large to be inlined.
 
Ok we are thinking to move definations in kernel/stacktrace.c
as a normal global function.
 

>in_irqentry_text() is probably too large to be inlined as well, and
>should return bool.

We can declare it as static funciton in kernel/stacktrace.c as its user
is only filter_irq_stacks.
 
>Declarations for __irqentry_text_start and friends already exist in
>include/asm-generic/sections.h (and, for some reason, also in
>arch/arm/include/asm/traps.h) and should not be duplicated in
>include/linux/stacktrace.h.

Ok, done.

Sending new patch with fixes.

Thanks.
Maninder Singh



 
 

Reply via email to