> On 28/03/2018 12:51, Niklas Cassel wrote: > cdns_pcie_ep_set_bar() does some round-up of the BAR size, which means that a > 64-bit BAR can be set-up, even when the flag > PCI_BASE_ADDRESS_MEM_TYPE_64 isn't set.
> If a 64-bit BAR was set-up, set the flag PCI_BASE_ADDRESS_MEM_TYPE_64, so > that the calling function can know what BAR width that was actually set-up. > I'm not sure why cdns_pcie_ep_set_bar() doesn't obey the flag > PCI_BASE_ADDRESS_MEM_TYPE_64, but I leave this for the MAINTAINER to fix, > since there might be a reason why > this flag is ignored. Will investigate and fix this in future patch > Signed-off-by: Niklas Cassel <niklas.cas...@axis.com> > --- > drivers/pci/cadence/pcie-cadence-ep.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/cadence/pcie-cadence-ep.c > b/drivers/pci/cadence/pcie-cadence-ep.c > index cef36cd6b710..2905e098678c 100644 > --- a/drivers/pci/cadence/pcie-cadence-ep.c > +++ b/drivers/pci/cadence/pcie-cadence-ep.c > @@ -106,6 +106,9 @@ static int cdns_pcie_ep_set_bar(struct pci_epc *epc, u8 > fn, > if (is_64bits && (bar & 1)) > return -EINVAL; > > + if (is_64bits && !(flags & PCI_BASE_ADDRESS_MEM_TYPE_64)) > + epf_bar->flags |= PCI_BASE_ADDRESS_MEM_TYPE_64; > + > if (is_64bits && is_prefetch) > ctrl = CDNS_PCIE_LM_BAR_CFG_CTRL_PREFETCH_MEM_64BITS; > else if (is_prefetch) > -- > 2.14.2 Change looks good to me.
