On Wednesday 28 March 2018 05:20 PM, Niklas Cassel wrote: > If a 64-bit BAR was set-up, we need to skip a BAR, > since a 64-bit BAR consists of a BAR pair. > > We need to check what BAR width the epc->ops->set_bar() specific > implementation actually did set-up, since some drivers, like the > Cadence EP controller, sometimes sets up a 64-bit BAR, even though > a 32-bit BAR was requested. > > Signed-off-by: Niklas Cassel <niklas.cas...@axis.com>
Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c > b/drivers/pci/endpoint/functions/pci-epf-test.c > index 91274779e59f..d46e3ebabb8e 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -380,6 +380,13 @@ static int pci_epf_test_set_bar(struct pci_epf *epf) > if (bar == test_reg_bar) > return ret; > } > + /* > + * pci_epc_set_bar() sets PCI_BASE_ADDRESS_MEM_TYPE_64 > + * if the specific implementation required a 64-bit BAR, > + * even if we only requested a 32-bit BAR. > + */ > + if (epf_bar->flags & PCI_BASE_ADDRESS_MEM_TYPE_64) > + bar++; > } > > return 0; >
