On Fri, Apr 6, 2018 at 9:25 AM, Tobias Regnery <tobias.regn...@gmail.com> wrote: > Commit 58eb5b670747 ("pstore: fix crypto dependencies") fixed up the crypto > dependencies but missed the case when no compression is selected. > > With CONFIG_PSTORE=y, CONFIG_PSTORE_COMPRESS=n and CONFIG_CRYPTO=m we see > the following link error: > > fs/pstore/platform.o: In function `pstore_register': > (.text+0x1b1): undefined reference to `crypto_has_alg' > (.text+0x205): undefined reference to `crypto_alloc_base' > fs/pstore/platform.o: In function `pstore_unregister': > (.text+0x3b0): undefined reference to `crypto_destroy_tfm' > > Fix this by checking at compile-time if CONFIG_PSTORE_COMPRESS is enabled. > > Fixes: 58eb5b670747 ("pstore: fix crypto dependencies") > Signed-off-by: Tobias Regnery <tobias.regn...@gmail.com> > --- > v2: check the config at compile-time rather than change the > kconfig-dependency as suggested by Arnd.
Thanks! Acked-by: Arnd Bergmann <a...@arndb.de>