On 13-Apr 13:29, Peter Zijlstra wrote: > On Fri, Apr 13, 2018 at 12:17:53PM +0100, Patrick Bellasi wrote: > > On 13-Apr 10:40, Peter Zijlstra wrote: > > > On Mon, Apr 09, 2018 at 05:56:09PM +0100, Patrick Bellasi wrote: > > > > +static inline void init_uclamp(void) > > > > > > WTH is that inline? > > > > You mean I can avoid the attribute? > > ... or that I should do it in another way? > > yea, its init code, no need to go all inline with that (gcc will likely > inline it anyway because static-with-single-callsite).
Yes, indeed... I think I've just got the right above init_schedstats() as a reference and lazily want for code consistency :( However, if we remove inline, we should probably still add an __init, isn't it? -- #include <best/regards.h> Patrick Bellasi
